New network menu button UI for ChromeOS....

New network menu button UI for ChromeOS.
Added ability to change label font in gtk menu item.
TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39516

[Charlie Lee, 2010-02-19 22:01:31]

Scott, can you take a look? Thanks.

[sky, 2010-02-19 22:23:21]

http://codereview.chromium.org/650074/diff/1/5
File views/controls/menu/native_menu_gtk.cc (right):

http://codereview.chromium.org/650074/diff/1/5#newcode243
views/controls/menu/native_menu_gtk.cc:243: }
I think you want something like:

GtkWidget* label_widget= GTK_BIN(menu_item)->child;
DCHECK(label_widget&& GTK_IS_LABEL(label_widget));

Does this work for radio button/checkboxs though?

[Charlie Lee, 2010-02-19 23:27:13]

http://codereview.chromium.org/650074/diff/1/5
File views/controls/menu/native_menu_gtk.cc (right):

http://codereview.chromium.org/650074/diff/1/5#newcode243
views/controls/menu/native_menu_gtk.cc:243: }
On 2010/02/19 22:23:21, sky wrote:
> I think you want something like:
> 
> GtkWidget* label_widget= GTK_BIN(menu_item)->child;
> DCHECK(label_widget&& GTK_IS_LABEL(label_widget));
> 
> Does this work for radio button/checkboxs though?

Done.

[sky, 2010-02-19 23:34:14]

LGTM with the following change.

http://codereview.chromium.org/650074/diff/1007/27
File views/controls/menu/native_menu_gtk.cc (right):

http://codereview.chromium.org/650074/diff/1007/27#newcode241
views/controls/menu/native_menu_gtk.cc:241:
gtk_widget_modify_font(GTK_WIDGET(label_widget),
You don't need GTK_WIDGET() here, just label_widget.