src/x64/full-codegen-x64.cc - Issue 650073002: vector-based ICs did not update type feedback counts correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed problematic field TypeFeedbackInfo::feedback_vector(). Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 0d931141ed0652d6028d80299fba1a02c29520d0..0caf855f8c7fe2a1a5a1978749c8768456efdf73 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -1149,7 +1149,8 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// No need for a write barrier, we are storing a Smi in the feedback vector.

__ Move(rbx, FeedbackVector());

- __ Move(FieldOperand(rbx, FixedArray::OffsetOfElementAt(slot.ToInt())),

+ int vector_index = FeedbackVector()->GetIndex(slot);

+ __ Move(FieldOperand(rbx, FixedArray::OffsetOfElementAt(vector_index)),

TypeFeedbackVector::MegamorphicSentinel(isolate()));

__ Move(rbx, Smi::FromInt(1)); // Smi indicates slow check

__ movp(rcx, Operand(rsp, 0 * kPointerSize)); // Get enumerated object

« src/type-feedback-vector-inl.h ('K') | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »