src/ia32/full-codegen-ia32.cc - Issue 650073002: vector-based ICs did not update type feedback counts correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed problematic field TypeFeedbackInfo::feedback_vector(). Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index fa68870fd77df768d928485baeb4a5197aa2d9f9..dd20946a3f2b061e2d37c9a848d8fefaa717450f 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -1117,7 +1117,8 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// No need for a write barrier, we are storing a Smi in the feedback vector.

__ LoadHeapObject(ebx, FeedbackVector());

- __ mov(FieldOperand(ebx, FixedArray::OffsetOfElementAt(slot.ToInt())),

+ int vector_index = FeedbackVector()->GetIndex(slot);

+ __ mov(FieldOperand(ebx, FixedArray::OffsetOfElementAt(vector_index)),

Immediate(TypeFeedbackVector::MegamorphicSentinel(isolate())));

__ mov(ebx, Immediate(Smi::FromInt(1))); // Smi indicates slow check

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | src/type-feedback-vector-inl.h » ('J')