src/heap/objects-visiting-inl.h - Issue 650073002: vector-based ICs did not update type feedback counts correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting-inl.h

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed problematic field TypeFeedbackInfo::feedback_vector(). Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/objects-visiting-inl.h

diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h

index d220118368e77d07b973ec92c701061ddf06b6a5..08009b182ab14d4bbcd6be0a2eea311cec1e3454 100644

--- a/src/heap/objects-visiting-inl.h

+++ b/src/heap/objects-visiting-inl.h

@@ -260,6 +260,7 @@ void StaticMarkingVisitor<StaticVisitor>::VisitCodeTarget(Heap* heap,

// when they might be keeping a Context alive, or when the heap is about

// to be serialized.

if (FLAG_cleanup_code_caches_at_gc && target->is_inline_cache_stub() &&

+ !target->is_call_stub() &&

(target->ic_state() == MEGAMORPHIC || target->ic_state() == GENERIC ||

target->ic_state() == POLYMORPHIC ||

(heap->flush_monomorphic_ics() && !target->is_weak_stub()) ||

« no previous file with comments | « src/full-codegen.cc ('k') | src/hydrogen-instructions.h » ('j') | src/type-feedback-vector-inl.h » ('J')