src/arm/full-codegen-arm.cc - Issue 650073002: vector-based ICs did not update type feedback counts correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed problematic field TypeFeedbackInfo::feedback_vector(). Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index 369f7146eb1aef781c05f1f6252a5fc2e99ea17c..e760a30fc081acd14b44d52c08a3685484f76bb1 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -1194,7 +1194,8 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ Move(r1, FeedbackVector());

__ mov(r2, Operand(TypeFeedbackVector::MegamorphicSentinel(isolate())));

- __ str(r2, FieldMemOperand(r1, FixedArray::OffsetOfElementAt(slot.ToInt())));

+ int vector_index = FeedbackVector()->GetIndex(slot);

+ __ str(r2, FieldMemOperand(r1, FixedArray::OffsetOfElementAt(vector_index)));

__ mov(r1, Operand(Smi::FromInt(1))); // Smi indicates slow check

__ ldr(r2, MemOperand(sp, 0 * kPointerSize)); // Get enumerated object

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | src/type-feedback-vector-inl.h » ('J')