Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: src/runtime-profiler.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime-profiler.cc
diff --git a/src/runtime-profiler.cc b/src/runtime-profiler.cc
index d6099d43be86001892e3f97e74bd08cca981da1c..b391d9af29d2bec389a197f7e3de97ab98eedc0c 100644
--- a/src/runtime-profiler.cc
+++ b/src/runtime-profiler.cc
@@ -69,6 +69,10 @@ static void GetICCounts(Code* shared_code, int* ic_with_type_info_count,
*ic_with_type_info_count = info->ic_with_type_info_count();
*ic_generic_count = info->ic_generic_count();
*ic_total_count = info->ic_total_count();
+ // Harvest vector-ics as well
Jakob Kummerow 2014/10/14 15:27:20 I think this should be moved out of the if-block (
mvstanton 2014/10/16 10:54:14 Hmm, I don't get it. If we have a TypeFeedbackInfo
+ TypeFeedbackVector* vector = info->feedback_vector();
+ *ic_with_type_info_count += vector->ic_with_type_info_count();
+ *ic_generic_count += vector->ic_generic_count();
}
if (*ic_total_count > 0) {
*type_info_percentage = 100 * *ic_with_type_info_count / *ic_total_count;

Powered by Google App Engine
This is Rietveld 408576698