Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2832 matching lines...) Expand 10 before | Expand all | Expand 10 after
2843 if (instr->hydrogen()->RequiresHoleCheck()) { 2843 if (instr->hydrogen()->RequiresHoleCheck()) {
2844 __ CompareRoot(result, Heap::kTheHoleValueRootIndex); 2844 __ CompareRoot(result, Heap::kTheHoleValueRootIndex);
2845 DeoptimizeIf(equal, instr, "hole"); 2845 DeoptimizeIf(equal, instr, "hole");
2846 } 2846 }
2847 } 2847 }
2848 2848
2849 2849
2850 template <class T> 2850 template <class T>
2851 void LCodeGen::EmitVectorLoadICRegisters(T* instr) { 2851 void LCodeGen::EmitVectorLoadICRegisters(T* instr) {
2852 DCHECK(FLAG_vector_ics); 2852 DCHECK(FLAG_vector_ics);
2853 Register vector = ToRegister(instr->temp_vector()); 2853 Register vector_register = ToRegister(instr->temp_vector());
2854 DCHECK(vector.is(VectorLoadICDescriptor::VectorRegister())); 2854 DCHECK(vector_register.is(VectorLoadICDescriptor::VectorRegister()));
2855 __ Move(vector, instr->hydrogen()->feedback_vector()); 2855 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector();
2856 __ Move(vector_register, vector);
2856 // No need to allocate this register. 2857 // No need to allocate this register.
2857 DCHECK(VectorLoadICDescriptor::SlotRegister().is(rax)); 2858 DCHECK(VectorLoadICDescriptor::SlotRegister().is(rax));
2858 __ Move(VectorLoadICDescriptor::SlotRegister(), 2859 int index = vector->GetIndex(instr->hydrogen()->slot());
2859 Smi::FromInt(instr->hydrogen()->slot().ToInt())); 2860 __ Move(VectorLoadICDescriptor::SlotRegister(), Smi::FromInt(index));
2860 } 2861 }
2861 2862
2862 2863
2863 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) { 2864 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) {
2864 DCHECK(ToRegister(instr->context()).is(rsi)); 2865 DCHECK(ToRegister(instr->context()).is(rsi));
2865 DCHECK(ToRegister(instr->global_object()) 2866 DCHECK(ToRegister(instr->global_object())
2866 .is(LoadDescriptor::ReceiverRegister())); 2867 .is(LoadDescriptor::ReceiverRegister()));
2867 DCHECK(ToRegister(instr->result()).is(rax)); 2868 DCHECK(ToRegister(instr->result()).is(rax));
2868 2869
2869 __ Move(LoadDescriptor::NameRegister(), instr->name()); 2870 __ Move(LoadDescriptor::NameRegister(), instr->name());
(...skipping 3011 matching lines...) Expand 10 before | Expand all | Expand 10 after
5881 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5882 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5882 RecordSafepoint(Safepoint::kNoLazyDeopt); 5883 RecordSafepoint(Safepoint::kNoLazyDeopt);
5883 } 5884 }
5884 5885
5885 5886
5886 #undef __ 5887 #undef __
5887 5888
5888 } } // namespace v8::internal 5889 } } // namespace v8::internal
5889 5890
5890 #endif // V8_TARGET_ARCH_X64 5891 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698