Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1131 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 __ bind(&no_descriptors); 1142 __ bind(&no_descriptors);
1143 __ addp(rsp, Immediate(kPointerSize)); 1143 __ addp(rsp, Immediate(kPointerSize));
1144 __ jmp(&exit); 1144 __ jmp(&exit);
1145 1145
1146 // We got a fixed array in register rax. Iterate through that. 1146 // We got a fixed array in register rax. Iterate through that.
1147 Label non_proxy; 1147 Label non_proxy;
1148 __ bind(&fixed_array); 1148 __ bind(&fixed_array);
1149 1149
1150 // No need for a write barrier, we are storing a Smi in the feedback vector. 1150 // No need for a write barrier, we are storing a Smi in the feedback vector.
1151 __ Move(rbx, FeedbackVector()); 1151 __ Move(rbx, FeedbackVector());
1152 __ Move(FieldOperand(rbx, FixedArray::OffsetOfElementAt(slot.ToInt())), 1152 int vector_index = FeedbackVector()->GetIndex(slot);
1153 __ Move(FieldOperand(rbx, FixedArray::OffsetOfElementAt(vector_index)),
1153 TypeFeedbackVector::MegamorphicSentinel(isolate())); 1154 TypeFeedbackVector::MegamorphicSentinel(isolate()));
1154 __ Move(rbx, Smi::FromInt(1)); // Smi indicates slow check 1155 __ Move(rbx, Smi::FromInt(1)); // Smi indicates slow check
1155 __ movp(rcx, Operand(rsp, 0 * kPointerSize)); // Get enumerated object 1156 __ movp(rcx, Operand(rsp, 0 * kPointerSize)); // Get enumerated object
1156 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE); 1157 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
1157 __ CmpObjectType(rcx, LAST_JS_PROXY_TYPE, rcx); 1158 __ CmpObjectType(rcx, LAST_JS_PROXY_TYPE, rcx);
1158 __ j(above, &non_proxy); 1159 __ j(above, &non_proxy);
1159 __ Move(rbx, Smi::FromInt(0)); // Zero indicates proxy 1160 __ Move(rbx, Smi::FromInt(0)); // Zero indicates proxy
1160 __ bind(&non_proxy); 1161 __ bind(&non_proxy);
1161 __ Push(rbx); // Smi 1162 __ Push(rbx); // Smi
1162 __ Push(rax); // Array 1163 __ Push(rax); // Array
(...skipping 3995 matching lines...) Expand 10 before | Expand all | Expand 10 after
5158 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5159 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5159 Assembler::target_address_at(call_target_address, 5160 Assembler::target_address_at(call_target_address,
5160 unoptimized_code)); 5161 unoptimized_code));
5161 return OSR_AFTER_STACK_CHECK; 5162 return OSR_AFTER_STACK_CHECK;
5162 } 5163 }
5163 5164
5164 5165
5165 } } // namespace v8::internal 5166 } } // namespace v8::internal
5166 5167
5167 #endif // V8_TARGET_ARCH_X64 5168 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698