Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: src/mips/code-stubs-mips.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/liveedit.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 2868 matching lines...) Expand 10 before | Expand all | Expand 10 after
2879 if (!FLAG_trace_ic) { 2879 if (!FLAG_trace_ic) {
2880 // We are going megamorphic. If the feedback is a JSFunction, it is fine 2880 // We are going megamorphic. If the feedback is a JSFunction, it is fine
2881 // to handle it here. More complex cases are dealt with in the runtime. 2881 // to handle it here. More complex cases are dealt with in the runtime.
2882 __ AssertNotSmi(t0); 2882 __ AssertNotSmi(t0);
2883 __ GetObjectType(t0, t1, t1); 2883 __ GetObjectType(t0, t1, t1);
2884 __ Branch(&miss, ne, t1, Operand(JS_FUNCTION_TYPE)); 2884 __ Branch(&miss, ne, t1, Operand(JS_FUNCTION_TYPE));
2885 __ sll(t0, a3, kPointerSizeLog2 - kSmiTagSize); 2885 __ sll(t0, a3, kPointerSizeLog2 - kSmiTagSize);
2886 __ Addu(t0, a2, Operand(t0)); 2886 __ Addu(t0, a2, Operand(t0));
2887 __ LoadRoot(at, Heap::kmegamorphic_symbolRootIndex); 2887 __ LoadRoot(at, Heap::kmegamorphic_symbolRootIndex);
2888 __ sw(at, FieldMemOperand(t0, FixedArray::kHeaderSize)); 2888 __ sw(at, FieldMemOperand(t0, FixedArray::kHeaderSize));
2889 // We have to update statistics for runtime profiling.
2890 const int with_types_offset =
2891 FixedArray::OffsetOfElementAt(TypeFeedbackVector::kWithTypesIndex);
2892 __ lw(t0, FieldMemOperand(a2, with_types_offset));
2893 __ Subu(t0, t0, Operand(Smi::FromInt(1)));
2894 __ sw(t0, FieldMemOperand(a2, with_types_offset));
2895 const int generic_offset =
2896 FixedArray::OffsetOfElementAt(TypeFeedbackVector::kGenericCountIndex);
2897 __ lw(t0, FieldMemOperand(a2, generic_offset));
2898 __ Addu(t0, t0, Operand(Smi::FromInt(1)));
2899 __ sw(t0, FieldMemOperand(a2, generic_offset));
2889 __ Branch(&slow_start); 2900 __ Branch(&slow_start);
2890 } 2901 }
2891 2902
2892 // We are here because tracing is on or we are going monomorphic. 2903 // We are here because tracing is on or we are going monomorphic.
2893 __ bind(&miss); 2904 __ bind(&miss);
2894 GenerateMiss(masm); 2905 GenerateMiss(masm);
2895 2906
2896 // the slow case 2907 // the slow case
2897 __ bind(&slow_start); 2908 __ bind(&slow_start);
2898 // Check that the function is really a JavaScript function. 2909 // Check that the function is really a JavaScript function.
(...skipping 2026 matching lines...) Expand 10 before | Expand all | Expand 10 after
4925 MemOperand(fp, 6 * kPointerSize), 4936 MemOperand(fp, 6 * kPointerSize),
4926 NULL); 4937 NULL);
4927 } 4938 }
4928 4939
4929 4940
4930 #undef __ 4941 #undef __
4931 4942
4932 } } // namespace v8::internal 4943 } } // namespace v8::internal
4933 4944
4934 #endif // V8_TARGET_ARCH_MIPS 4945 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/liveedit.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698