Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Side by Side Diff: src/ast.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast.h" 5 #include "src/ast.h"
6 6
7 #include <cmath> // For isfinite. 7 #include <cmath> // For isfinite.
8 #include "src/builtins.h" 8 #include "src/builtins.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/contexts.h" 10 #include "src/contexts.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 var_proxy->raw_name()->IsOneByteEqualTo("undefined"); 58 var_proxy->raw_name()->IsOneByteEqualTo("undefined");
59 } 59 }
60 60
61 61
62 VariableProxy::VariableProxy(Zone* zone, Variable* var, int position, 62 VariableProxy::VariableProxy(Zone* zone, Variable* var, int position,
63 IdGen* id_gen) 63 IdGen* id_gen)
64 : Expression(zone, position, 0, id_gen), 64 : Expression(zone, position, 0, id_gen),
65 is_this_(var->is_this()), 65 is_this_(var->is_this()),
66 is_assigned_(false), 66 is_assigned_(false),
67 is_resolved_(false), 67 is_resolved_(false),
68 variable_feedback_slot_(FeedbackVectorSlot::Invalid()), 68 variable_feedback_slot_(FeedbackVectorICSlot::Invalid()),
69 raw_name_(var->raw_name()), 69 raw_name_(var->raw_name()),
70 interface_(var->interface()) { 70 interface_(var->interface()) {
71 BindTo(var); 71 BindTo(var);
72 } 72 }
73 73
74 74
75 VariableProxy::VariableProxy(Zone* zone, const AstRawString* name, bool is_this, 75 VariableProxy::VariableProxy(Zone* zone, const AstRawString* name, bool is_this,
76 Interface* interface, int position, IdGen* id_gen) 76 Interface* interface, int position, IdGen* id_gen)
77 : Expression(zone, position, 0, id_gen), 77 : Expression(zone, position, 0, id_gen),
78 is_this_(is_this), 78 is_this_(is_this),
79 is_assigned_(false), 79 is_assigned_(false),
80 is_resolved_(false), 80 is_resolved_(false),
81 variable_feedback_slot_(FeedbackVectorSlot::Invalid()), 81 variable_feedback_slot_(FeedbackVectorICSlot::Invalid()),
82 raw_name_(name), 82 raw_name_(name),
83 interface_(interface) {} 83 interface_(interface) {}
84 84
85 85
86 void VariableProxy::BindTo(Variable* var) { 86 void VariableProxy::BindTo(Variable* var) {
87 DCHECK(!FLAG_harmony_modules || interface_->IsUnified(var->interface())); 87 DCHECK(!FLAG_harmony_modules || interface_->IsUnified(var->interface()));
88 DCHECK((is_this() && var->is_this()) || raw_name() == var->raw_name()); 88 DCHECK((is_this() && var->is_this()) || raw_name() == var->raw_name());
89 // Ideally CONST-ness should match. However, this is very hard to achieve 89 // Ideally CONST-ness should match. However, this is very hard to achieve
90 // because we don't know the exact semantics of conflicting (const and 90 // because we don't know the exact semantics of conflicting (const and
91 // non-const) multiple variable declarations, const vars introduced via 91 // non-const) multiple variable declarations, const vars introduced via
(...skipping 1053 matching lines...) Expand 10 before | Expand all | Expand 10 after
1145 // static 1145 // static
1146 bool Literal::Match(void* literal1, void* literal2) { 1146 bool Literal::Match(void* literal1, void* literal2) {
1147 const AstValue* x = static_cast<Literal*>(literal1)->raw_value(); 1147 const AstValue* x = static_cast<Literal*>(literal1)->raw_value();
1148 const AstValue* y = static_cast<Literal*>(literal2)->raw_value(); 1148 const AstValue* y = static_cast<Literal*>(literal2)->raw_value();
1149 return (x->IsString() && y->IsString() && *x->AsString() == *y->AsString()) || 1149 return (x->IsString() && y->IsString() && *x->AsString() == *y->AsString()) ||
1150 (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber()); 1150 (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber());
1151 } 1151 }
1152 1152
1153 1153
1154 } } // namespace v8::internal 1154 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698