Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm64/lithium-codegen-arm64.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/ast.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm64/lithium-codegen-arm64.h" 7 #include "src/arm64/lithium-codegen-arm64.h"
8 #include "src/arm64/lithium-gap-resolver-arm64.h" 8 #include "src/arm64/lithium-gap-resolver-arm64.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 3353 matching lines...) Expand 10 before | Expand all | Expand 10 after
3364 __ Ldr(result, FieldMemOperand(result, Cell::kValueOffset)); 3364 __ Ldr(result, FieldMemOperand(result, Cell::kValueOffset));
3365 if (instr->hydrogen()->RequiresHoleCheck()) { 3365 if (instr->hydrogen()->RequiresHoleCheck()) {
3366 DeoptimizeIfRoot(result, Heap::kTheHoleValueRootIndex, instr, "hole"); 3366 DeoptimizeIfRoot(result, Heap::kTheHoleValueRootIndex, instr, "hole");
3367 } 3367 }
3368 } 3368 }
3369 3369
3370 3370
3371 template <class T> 3371 template <class T>
3372 void LCodeGen::EmitVectorLoadICRegisters(T* instr) { 3372 void LCodeGen::EmitVectorLoadICRegisters(T* instr) {
3373 DCHECK(FLAG_vector_ics); 3373 DCHECK(FLAG_vector_ics);
3374 Register vector = ToRegister(instr->temp_vector()); 3374 Register vector_register = ToRegister(instr->temp_vector());
3375 DCHECK(vector.is(VectorLoadICDescriptor::VectorRegister())); 3375 DCHECK(vector_register.is(VectorLoadICDescriptor::VectorRegister()));
3376 __ Mov(vector, instr->hydrogen()->feedback_vector()); 3376 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector();
3377 __ Mov(vector_register, vector);
3377 // No need to allocate this register. 3378 // No need to allocate this register.
3378 DCHECK(VectorLoadICDescriptor::SlotRegister().is(x0)); 3379 DCHECK(VectorLoadICDescriptor::SlotRegister().is(x0));
3379 __ Mov(VectorLoadICDescriptor::SlotRegister(), 3380 int index = vector->GetIndex(instr->hydrogen()->slot());
3380 Smi::FromInt(instr->hydrogen()->slot().ToInt())); 3381 __ Mov(VectorLoadICDescriptor::SlotRegister(), Smi::FromInt(index));
3381 } 3382 }
3382 3383
3383 3384
3384 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) { 3385 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) {
3385 DCHECK(ToRegister(instr->context()).is(cp)); 3386 DCHECK(ToRegister(instr->context()).is(cp));
3386 DCHECK(ToRegister(instr->global_object()) 3387 DCHECK(ToRegister(instr->global_object())
3387 .is(LoadDescriptor::ReceiverRegister())); 3388 .is(LoadDescriptor::ReceiverRegister()));
3388 DCHECK(ToRegister(instr->result()).Is(x0)); 3389 DCHECK(ToRegister(instr->result()).Is(x0));
3389 __ Mov(LoadDescriptor::NameRegister(), Operand(instr->name())); 3390 __ Mov(LoadDescriptor::NameRegister(), Operand(instr->name()));
3390 if (FLAG_vector_ics) { 3391 if (FLAG_vector_ics) {
(...skipping 2649 matching lines...) Expand 10 before | Expand all | Expand 10 after
6040 Handle<ScopeInfo> scope_info = instr->scope_info(); 6041 Handle<ScopeInfo> scope_info = instr->scope_info();
6041 __ Push(scope_info); 6042 __ Push(scope_info);
6042 __ Push(ToRegister(instr->function())); 6043 __ Push(ToRegister(instr->function()));
6043 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6044 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6044 RecordSafepoint(Safepoint::kNoLazyDeopt); 6045 RecordSafepoint(Safepoint::kNoLazyDeopt);
6045 } 6046 }
6046 6047
6047 6048
6048 6049
6049 } } // namespace v8::internal 6050 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/ast.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698