Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1163 matching lines...) Expand 10 before | Expand all | Expand 10 after
1174 1174
1175 __ Bind(&no_descriptors); 1175 __ Bind(&no_descriptors);
1176 __ Drop(1); 1176 __ Drop(1);
1177 __ B(&exit); 1177 __ B(&exit);
1178 1178
1179 // We got a fixed array in register x0. Iterate through that. 1179 // We got a fixed array in register x0. Iterate through that.
1180 __ Bind(&fixed_array); 1180 __ Bind(&fixed_array);
1181 1181
1182 __ LoadObject(x1, FeedbackVector()); 1182 __ LoadObject(x1, FeedbackVector());
1183 __ Mov(x10, Operand(TypeFeedbackVector::MegamorphicSentinel(isolate()))); 1183 __ Mov(x10, Operand(TypeFeedbackVector::MegamorphicSentinel(isolate())));
1184 __ Str(x10, FieldMemOperand(x1, FixedArray::OffsetOfElementAt(slot.ToInt()))); 1184 int vector_index = FeedbackVector()->GetIndex(slot);
1185 __ Str(x10, FieldMemOperand(x1, FixedArray::OffsetOfElementAt(vector_index)));
1185 1186
1186 __ Mov(x1, Smi::FromInt(1)); // Smi indicates slow check. 1187 __ Mov(x1, Smi::FromInt(1)); // Smi indicates slow check.
1187 __ Peek(x10, 0); // Get enumerated object. 1188 __ Peek(x10, 0); // Get enumerated object.
1188 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE); 1189 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);
1189 // TODO(all): similar check was done already. Can we avoid it here? 1190 // TODO(all): similar check was done already. Can we avoid it here?
1190 __ CompareObjectType(x10, x11, x12, LAST_JS_PROXY_TYPE); 1191 __ CompareObjectType(x10, x11, x12, LAST_JS_PROXY_TYPE);
1191 DCHECK(Smi::FromInt(0) == 0); 1192 DCHECK(Smi::FromInt(0) == 0);
1192 __ CzeroX(x1, le); // Zero indicates proxy. 1193 __ CzeroX(x1, le); // Zero indicates proxy.
1193 __ Ldr(x2, FieldMemOperand(x0, FixedArray::kLengthOffset)); 1194 __ Ldr(x2, FieldMemOperand(x0, FixedArray::kLengthOffset));
1194 // Smi and array, fixed array length (as smi) and initial index. 1195 // Smi and array, fixed array length (as smi) and initial index.
(...skipping 4049 matching lines...) Expand 10 before | Expand all | Expand 10 after
5244 return previous_; 5245 return previous_;
5245 } 5246 }
5246 5247
5247 5248
5248 #undef __ 5249 #undef __
5249 5250
5250 5251
5251 } } // namespace v8::internal 5252 } } // namespace v8::internal
5252 5253
5253 #endif // V8_TARGET_ARCH_ARM64 5254 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm64/code-stubs-arm64.cc ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698