Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/arm64/code-stubs-arm64.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3060 matching lines...) Expand 10 before | Expand all | Expand 10 after
3071 3071
3072 if (!FLAG_trace_ic) { 3072 if (!FLAG_trace_ic) {
3073 // We are going megamorphic. If the feedback is a JSFunction, it is fine 3073 // We are going megamorphic. If the feedback is a JSFunction, it is fine
3074 // to handle it here. More complex cases are dealt with in the runtime. 3074 // to handle it here. More complex cases are dealt with in the runtime.
3075 __ AssertNotSmi(x4); 3075 __ AssertNotSmi(x4);
3076 __ JumpIfNotObjectType(x4, x5, x5, JS_FUNCTION_TYPE, &miss); 3076 __ JumpIfNotObjectType(x4, x5, x5, JS_FUNCTION_TYPE, &miss);
3077 __ Add(x4, feedback_vector, 3077 __ Add(x4, feedback_vector,
3078 Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 3078 Operand::UntagSmiAndScale(index, kPointerSizeLog2));
3079 __ LoadRoot(x5, Heap::kmegamorphic_symbolRootIndex); 3079 __ LoadRoot(x5, Heap::kmegamorphic_symbolRootIndex);
3080 __ Str(x5, FieldMemOperand(x4, FixedArray::kHeaderSize)); 3080 __ Str(x5, FieldMemOperand(x4, FixedArray::kHeaderSize));
3081 // We have to update statistics for runtime profiling.
3082 const int with_types_offset =
3083 FixedArray::OffsetOfElementAt(TypeFeedbackVector::kWithTypesIndex);
3084 __ Ldr(x4, FieldMemOperand(feedback_vector, with_types_offset));
3085 __ Subs(x4, x4, Operand(Smi::FromInt(1)));
3086 __ Str(x4, FieldMemOperand(feedback_vector, with_types_offset));
3087 const int generic_offset =
3088 FixedArray::OffsetOfElementAt(TypeFeedbackVector::kGenericCountIndex);
3089 __ Ldr(x4, FieldMemOperand(feedback_vector, generic_offset));
3090 __ Adds(x4, x4, Operand(Smi::FromInt(1)));
3091 __ Str(x4, FieldMemOperand(feedback_vector, generic_offset));
3081 __ B(&slow_start); 3092 __ B(&slow_start);
3082 } 3093 }
3083 3094
3084 // We are here because tracing is on or we are going monomorphic. 3095 // We are here because tracing is on or we are going monomorphic.
3085 __ bind(&miss); 3096 __ bind(&miss);
3086 GenerateMiss(masm); 3097 GenerateMiss(masm);
3087 3098
3088 // the slow case 3099 // the slow case
3089 __ bind(&slow_start); 3100 __ bind(&slow_start);
3090 3101
(...skipping 1999 matching lines...) Expand 10 before | Expand all | Expand 10 after
5090 MemOperand(fp, 6 * kPointerSize), 5101 MemOperand(fp, 6 * kPointerSize),
5091 NULL); 5102 NULL);
5092 } 5103 }
5093 5104
5094 5105
5095 #undef __ 5106 #undef __
5096 5107
5097 } } // namespace v8::internal 5108 } } // namespace v8::internal
5098 5109
5099 #endif // V8_TARGET_ARCH_ARM64 5110 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698