Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-codegen-arm.h" 7 #include "src/arm/lithium-codegen-arm.h"
8 #include "src/arm/lithium-gap-resolver-arm.h" 8 #include "src/arm/lithium-gap-resolver-arm.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2976 matching lines...) Expand 10 before | Expand all | Expand 10 after
2987 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 2987 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
2988 __ cmp(result, ip); 2988 __ cmp(result, ip);
2989 DeoptimizeIf(eq, instr, "hole"); 2989 DeoptimizeIf(eq, instr, "hole");
2990 } 2990 }
2991 } 2991 }
2992 2992
2993 2993
2994 template <class T> 2994 template <class T>
2995 void LCodeGen::EmitVectorLoadICRegisters(T* instr) { 2995 void LCodeGen::EmitVectorLoadICRegisters(T* instr) {
2996 DCHECK(FLAG_vector_ics); 2996 DCHECK(FLAG_vector_ics);
2997 Register vector = ToRegister(instr->temp_vector()); 2997 Register vector_register = ToRegister(instr->temp_vector());
2998 DCHECK(vector.is(VectorLoadICDescriptor::VectorRegister())); 2998 DCHECK(vector_register.is(VectorLoadICDescriptor::VectorRegister()));
2999 __ Move(vector, instr->hydrogen()->feedback_vector()); 2999 Handle<TypeFeedbackVector> vector = instr->hydrogen()->feedback_vector();
3000 __ Move(vector_register, vector);
3000 // No need to allocate this register. 3001 // No need to allocate this register.
3001 DCHECK(VectorLoadICDescriptor::SlotRegister().is(r0)); 3002 DCHECK(VectorLoadICDescriptor::SlotRegister().is(r0));
3002 __ mov(VectorLoadICDescriptor::SlotRegister(), 3003 int index = vector->GetIndex(instr->hydrogen()->slot());
3003 Operand(Smi::FromInt(instr->hydrogen()->slot().ToInt()))); 3004 __ mov(VectorLoadICDescriptor::SlotRegister(), Operand(Smi::FromInt(index)));
3004 } 3005 }
3005 3006
3006 3007
3007 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) { 3008 void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) {
3008 DCHECK(ToRegister(instr->context()).is(cp)); 3009 DCHECK(ToRegister(instr->context()).is(cp));
3009 DCHECK(ToRegister(instr->global_object()) 3010 DCHECK(ToRegister(instr->global_object())
3010 .is(LoadDescriptor::ReceiverRegister())); 3011 .is(LoadDescriptor::ReceiverRegister()));
3011 DCHECK(ToRegister(instr->result()).is(r0)); 3012 DCHECK(ToRegister(instr->result()).is(r0));
3012 3013
3013 __ mov(LoadDescriptor::NameRegister(), Operand(instr->name())); 3014 __ mov(LoadDescriptor::NameRegister(), Operand(instr->name()));
(...skipping 2890 matching lines...) Expand 10 before | Expand all | Expand 10 after
5904 __ Push(scope_info); 5905 __ Push(scope_info);
5905 __ push(ToRegister(instr->function())); 5906 __ push(ToRegister(instr->function()));
5906 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5907 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5907 RecordSafepoint(Safepoint::kNoLazyDeopt); 5908 RecordSafepoint(Safepoint::kNoLazyDeopt);
5908 } 5909 }
5909 5910
5910 5911
5911 #undef __ 5912 #undef __
5912 5913
5913 } } // namespace v8::internal 5914 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698