src/mips/full-codegen-mips.cc - Issue 650073002: vector-based ICs did not update type feedback counts correctly.

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 650073002: vector-based ICs did not update type feedback counts correctly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Removed problematic field TypeFeedbackInfo::feedback_vector(). Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2012 the V8 project authors. All rights reserved.	1 // Copyright 2012 the V8 project authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "src/v8.h"	5 #include "src/v8.h"

6	6

7 #if V8_TARGET_ARCH_MIPS	7 #if V8_TARGET_ARCH_MIPS

8	8

9 // Note on Mips implementation:	9 // Note on Mips implementation:

10 //	10 //

(...skipping 1163 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1174 __ bind(&no_descriptors);	1174 __ bind(&no_descriptors);

1175 __ Drop(1);	1175 __ Drop(1);

1176 __ jmp(&exit);	1176 __ jmp(&exit);

1177	1177

1178 // We got a fixed array in register v0. Iterate through that.	1178 // We got a fixed array in register v0. Iterate through that.

1179 Label non_proxy;	1179 Label non_proxy;

1180 __ bind(&fixed_array);	1180 __ bind(&fixed_array);

1181	1181

1182 __ li(a1, FeedbackVector());	1182 __ li(a1, FeedbackVector());

1183 __ li(a2, Operand(TypeFeedbackVector::MegamorphicSentinel(isolate())));	1183 __ li(a2, Operand(TypeFeedbackVector::MegamorphicSentinel(isolate())));

1184 __ sw(a2, FieldMemOperand(a1, FixedArray::OffsetOfElementAt(slot.ToInt())));	1184 int vector_index = FeedbackVector()->GetIndex(slot);

	1185 __ sw(a2, FieldMemOperand(a1, FixedArray::OffsetOfElementAt(vector_index)));

1185	1186

1186 __ li(a1, Operand(Smi::FromInt(1))); // Smi indicates slow check	1187 __ li(a1, Operand(Smi::FromInt(1))); // Smi indicates slow check

1187 __ lw(a2, MemOperand(sp, 0 * kPointerSize)); // Get enumerated object	1188 __ lw(a2, MemOperand(sp, 0 * kPointerSize)); // Get enumerated object

1188 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);	1189 STATIC_ASSERT(FIRST_JS_PROXY_TYPE == FIRST_SPEC_OBJECT_TYPE);

1189 __ GetObjectType(a2, a3, a3);	1190 __ GetObjectType(a2, a3, a3);

1190 __ Branch(&non_proxy, gt, a3, Operand(LAST_JS_PROXY_TYPE));	1191 __ Branch(&non_proxy, gt, a3, Operand(LAST_JS_PROXY_TYPE));

1191 __ li(a1, Operand(Smi::FromInt(0))); // Zero indicates proxy	1192 __ li(a1, Operand(Smi::FromInt(0))); // Zero indicates proxy

1192 __ bind(&non_proxy);	1193 __ bind(&non_proxy);

1193 __ Push(a1, v0); // Smi and array	1194 __ Push(a1, v0); // Smi and array

1194 __ lw(a1, FieldMemOperand(v0, FixedArray::kLengthOffset));	1195 __ lw(a1, FieldMemOperand(v0, FixedArray::kLengthOffset));

(...skipping 3942 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
5137 Assembler::target_address_at(pc_immediate_load_address)) ==	5138 Assembler::target_address_at(pc_immediate_load_address)) ==

5138 reinterpret_cast<uint32_t>(	5139 reinterpret_cast<uint32_t>(

5139 isolate->builtins()->OsrAfterStackCheck()->entry()));	5140 isolate->builtins()->OsrAfterStackCheck()->entry()));

5140 return OSR_AFTER_STACK_CHECK;	5141 return OSR_AFTER_STACK_CHECK;

5141 }	5142 }

5142	5143

5143	5144

5144 } } // namespace v8::internal	5145 } } // namespace v8::internal

5145	5146

5146 #endif // V8_TARGET_ARCH_MIPS	5147 #endif // V8_TARGET_ARCH_MIPS

OLD	NEW

« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | src/type-feedback-vector-inl.h » ('J')