vector-based ICs did not update type feedback counts correctly.

src/runtime-profiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/runtime-profiler.h"
 
 #include "src/assembler.h"
 #include "src/base/platform/platform.h"
@@ skipping 51 matching lines @@
                         int* type_info_percentage, int* generic_percentage) {
   *ic_total_count = 0;
   *ic_generic_count = 0;
   *ic_with_type_info_count = 0;
   Object* raw_info = shared_code->type_feedback_info();
   if (raw_info->IsTypeFeedbackInfo()) {
     TypeFeedbackInfo* info = TypeFeedbackInfo::cast(raw_info);
     *ic_with_type_info_count = info->ic_with_type_info_count();
     *ic_generic_count = info->ic_generic_count();
     *ic_total_count = info->ic_total_count();
+    // Harvest vector-ics as well

[Jakob Kummerow, 2014/10/14 15:27:20]

I think this should be moved out of the if-block (but maybe needs its own vector
presence check instead?).

[mvstanton, 2014/10/16 10:54:14]

Hmm, I don't get it. If we have a TypeFeedbackInfo then it'll have a valid
feedback_vector in it, so what would moving it out of the if block help?

+    TypeFeedbackVector* vector = info->feedback_vector();
+    *ic_with_type_info_count += vector->ic_with_type_info_count();
+    *ic_generic_count += vector->ic_generic_count();
   }
   if (*ic_total_count > 0) {
     *type_info_percentage = 100 * *ic_with_type_info_count / *ic_total_count;
     *generic_percentage = 100 * *ic_generic_count / *ic_total_count;
   } else {
     *type_info_percentage = 100;  // Compared against lower bound.
     *generic_percentage = 0;      // Compared against upper bound.
   }
 }
 
@@ skipping 187 matching lines @@
       }
     } else {
       shared_code->set_profiler_ticks(ticks + 1);
     }
   }
   any_ic_changed_ = false;
 }
 
 
 } }  // namespace v8::internal