Issue 650033006: Revert "Enabled the App Info dialog on the Extensions page by default"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650033006: Revert "Enabled the App Info dialog on the Extensions page by default" (Closed)

Created:
6 years, 1 month ago by kochi

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert "Enabled the App Info dialog on the Extensions page by default" This reverts commit a867ca2b5e42207b65e9d07702138ff79bed0bb0. This CL forgot to change chrome/browser/ui/webui/extensions/extension_settings_handler.cc which resulted in compilation errors. E.g. http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Full/builds/6096 BUG=426717 TBR=sashab@chromium.org, thestig@chromium.org, asvitkine@chromium.org, benwells@chromium.org, mpearson@chromium.org Committed: https://crrev.com/6acc970aef0fe3627ee0786b6c07fb690feabd47 Cr-Commit-Position: refs/heads/master@{#301030}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -36 lines)			Patch
M	chrome/app/generated_resources.grd	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_settings_handler.cc	View	3 chunks	+4 lines, -15 lines	0 comments	Download
M	extensions/common/switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/switches.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

kochi

Committed patchset #1 (id:1) manually as 6acc970aef0fe3627ee0786b6c07fb690feabd47 (presubmit successful).

6 years, 1 month ago (2014-10-24 02:09:21 UTC) #1

commit-bot: I haz the power

6 years, 1 month ago (2014-10-24 02:09:21 UTC) #2

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6acc970aef0fe3627ee0786b6c07fb690feabd47
Cr-Commit-Position: refs/heads/master@{#301030}