Issue 650033002: Oilpan: fix ref counting of derived SVG property objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 650033002: Oilpan: fix ref counting of derived SVG property objects. (Closed)

Created:
6 years, 2 months ago by sof

Modified:
6 years, 2 months ago

Reviewers:
haraken, oilpan-reviews

CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix ref counting of derived SVG property objects. Following r183582, RefCountedGarbageCollected<T>::m_refCount is left as 0. This is incompatible with the derived SVG objects which have a base object (SVGPropertyBase) that's a RefCountedGarbageCollected<> object, but the derived objects are all exposed as if they were deriving from a RefCounted<T> base. Adjust the ref count upon construction of SVGPropertyBase to provide that illusion. TBR=haraken,oilpan-reviews BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183586