Source/web/WebLocalFrameImpl.cpp - Issue 650023003: Make generateReferrerHeader() return a Referrer instead of a String

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 650023003: Make generateReferrerHeader() return a Referrer instead of a String (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index c508c7f825670dc38d164d6192373edcbba25fd8..8dab932675e648cae512e01d43219ca9a8f8fa7a 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -923,11 +923,8 @@ bool WebLocalFrameImpl::isViewSourceModeEnabled() const

void WebLocalFrameImpl::setReferrerForRequest(WebURLRequest& request, const WebURL& referrerURL)

{

- String referrer = referrerURL.isEmpty() ? frame()->document()->outgoingReferrer() : String(referrerURL.spec().utf16());

- referrer = SecurityPolicy::generateReferrerHeader(frame()->document()->referrerPolicy(), request.url(), referrer);

- if (referrer.isEmpty())

- return;

- request.setHTTPReferrer(referrer, static_cast<WebReferrerPolicy>(frame()->document()->referrerPolicy()));

+ String referrerString = referrerURL.isEmpty() ? frame()->document()->outgoingReferrer() : String(referrerURL.spec().utf16());

+ request.toMutableResourceRequest().setHTTPReferrer(SecurityPolicy::generateReferrerHeader(frame()->document()->referrerPolicy(), request.url(), referrerString));

}

void WebLocalFrameImpl::dispatchWillSendRequest(WebURLRequest& request)

« no previous file with comments | « Source/platform/weborigin/SecurityPolicyTest.cpp ('k') | Source/web/WebSecurityPolicy.cpp » ('j') | Source/web/WebSecurityPolicy.cpp » ('J')