Make generateReferrerHeader() return a Referrer instead of a String

Make generateReferrerHeader() return a Referrer instead of a String

Rename it to generateReferrer() to better match its return type.

Also, make setHTTPReferrer() remove the header if the value parameter is empty. There shouldn't ever be a reason to send an empty referrer header (rather than not sending a referrer header at all), so this enables us to enforce this property in one place, rather than several.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183838

[Nate Chapin, 2014-10-15 16:11:19]

japhet@chromium.org changed reviewers:
+ jochen@chromium.org

[Nate Chapin, 2014-10-15 16:11:20]

This looks cleaner to me, but I'm happy to be outvoted if there's a good reason
for the old way :)

[Mike West, 2014-10-16 10:52:51]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-10-16 10:52:51]

Perhaps rename 'generateReferrerHeader' to 'generateReferrer'? Otherwise this
looks more readable to me than the existing code: LGTM.

[Nate Chapin, 2014-10-16 18:08:48]

On 2014/10/16 10:52:51, Mike West wrote:
> Perhaps rename 'generateReferrerHeader' to 'generateReferrer'? Otherwise this
> looks more readable to me than the existing code: LGTM.

That makes sense, will update before landing.

[Nate Chapin, 2014-10-16 18:26:23]

https://codereview.chromium.org/650023003/diff/360001/Source/web/WebSecurityP...
File Source/web/WebSecurityPolicy.cpp (right):

https://codereview.chromium.org/650023003/diff/360001/Source/web/WebSecurityP...
Source/web/WebSecurityPolicy.cpp:105: WebString
WebSecurityPolicy::generateReferrerHeader(WebReferrerPolicy referrerPolicy,
const WebURL& url, const WebString& referrer)
FYI, I'm going to leave this function name as generateReferrerHeader(), since it
will still return a WebString.

[Nate Chapin, 2014-10-16 18:32:18]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-10-16 18:33:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650023003/380001

[Mike West, 2014-10-16 18:33:39]

On 2014/10/16 18:26:23, Nate Chapin wrote:
>
https://codereview.chromium.org/650023003/diff/360001/Source/web/WebSecurityP...
> File Source/web/WebSecurityPolicy.cpp (right):
> 
>
https://codereview.chromium.org/650023003/diff/360001/Source/web/WebSecurityP...
> Source/web/WebSecurityPolicy.cpp:105: WebString
> WebSecurityPolicy::generateReferrerHeader(WebReferrerPolicy referrerPolicy,
> const WebURL& url, const WebString& referrer)
> FYI, I'm going to leave this function name as generateReferrerHeader(), since
it
> will still return a WebString.

Sounds good.

[commit-bot: I haz the power, 2014-10-16 20:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 20:46:14]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32130)

[Nate Chapin, 2014-10-16 20:48:44]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-10-16 20:49:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650023003/380001

[commit-bot: I haz the power, 2014-10-16 21:36:54]

Committed patchset #5 (id:380001) as 183838