Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 650013007: Fix help text size calculation for password gen bubble on Mac. (Closed)

Created:
6 years, 2 months ago by dconnelly
Modified:
6 years, 2 months ago
Reviewers:
*groby-ooo-7-16
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org, Garrett Casto
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix help text size calculation for password gen bubble on Mac. BUG=423945 Committed: https://crrev.com/2ca5c651adaea6e380f9204f534e9c618df9615b Cr-Commit-Position: refs/heads/master@{#300696}

Patch Set 1 #

Total comments: 2

Patch Set 2 : helpWidth -> contentWidth #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dconnelly
6 years, 2 months ago (2014-10-22 10:58:29 UTC) #3
groby-ooo-7-16
LGTM w/ naming nit https://codereview.chromium.org/650013007/diff/1/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm File chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm (right): https://codereview.chromium.org/650013007/diff/1/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm#newcode167 chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm:167: CGFloat helpWidth = width - ...
6 years, 2 months ago (2014-10-22 15:00:20 UTC) #4
dconnelly
https://codereview.chromium.org/650013007/diff/1/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm File chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm (right): https://codereview.chromium.org/650013007/diff/1/chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm#newcode167 chrome/browser/ui/cocoa/autofill/password_generation_popup_view_cocoa.mm:167: CGFloat helpWidth = width - (2 * controller_->kHorizontalPadding); On ...
6 years, 2 months ago (2014-10-22 15:04:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650013007/20001
6 years, 2 months ago (2014-10-22 15:06:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 17:36:56 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:37:38 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2ca5c651adaea6e380f9204f534e9c618df9615b
Cr-Commit-Position: refs/heads/master@{#300696}

Powered by Google App Engine
This is Rietveld 408576698