Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 649933006: Move PostMessageToFrame to WebContentsAndroid (Closed)

Created:
6 years, 2 months ago by sgurun-gerrit only
Modified:
6 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move PostMessageToFrame to WebContentsAndroid Move PostMessageToFrame method from ContentViewCore to WebContentsAndroid which is a more suitable location. BUG=393291 Committed: https://crrev.com/5ea4ad8707a1be0cc3edfcf2eb70708f55e15e5d Cr-Commit-Position: refs/heads/master@{#300615}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : address code review #

Messages

Total messages: 10 (3 generated)
sgurun-gerrit only
On 2014/10/21 18:28:57, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:tedchoc@chromium.org PTAL, thanks
6 years, 2 months ago (2014-10-21 18:30:05 UTC) #3
Ted C
https://codereview.chromium.org/649933006/diff/40001/content/browser/web_contents/web_contents_android.cc File content/browser/web_contents/web_contents_android.cc (right): https://codereview.chromium.org/649933006/diff/40001/content/browser/web_contents/web_contents_android.cc#newcode375 content/browser/web_contents/web_contents_android.cc:375: return; indented two too many https://codereview.chromium.org/649933006/diff/40001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): ...
6 years, 2 months ago (2014-10-21 21:36:57 UTC) #4
sgurun-gerrit only
https://codereview.chromium.org/649933006/diff/40001/content/browser/web_contents/web_contents_android.cc File content/browser/web_contents/web_contents_android.cc (right): https://codereview.chromium.org/649933006/diff/40001/content/browser/web_contents/web_contents_android.cc#newcode375 content/browser/web_contents/web_contents_android.cc:375: return; On 2014/10/21 21:36:56, Ted C wrote: > indented ...
6 years, 2 months ago (2014-10-21 23:43:35 UTC) #5
Ted C
lgtm
6 years, 2 months ago (2014-10-21 23:44:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649933006/60001
6 years, 2 months ago (2014-10-21 23:50:40 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 2 months ago (2014-10-22 01:56:35 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:05:18 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ea4ad8707a1be0cc3edfcf2eb70708f55e15e5d
Cr-Commit-Position: refs/heads/master@{#300615}

Powered by Google App Engine
This is Rietveld 408576698