chrome/renderer/chrome_content_renderer_client.cc - Issue 649873006: Enable shadow DOM-based "missing plugin" placeholder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 649873006: Enable shadow DOM-based "missing plugin" placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments (thestig, sievers) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | chrome/renderer/chrome_content_renderer_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 9f99262d1107d5279a117484abf56333be0263a1..475f74eeed15e29fe115865cbba2b73ebfc7fd55 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -45,6 +45,7 @@

#include "chrome/renderer/playback_extension.h"

#include "chrome/renderer/plugins/chrome_plugin_placeholder.h"

#include "chrome/renderer/plugins/plugin_uma.h"

+#include "chrome/renderer/plugins/shadow_dom_plugin_placeholder.h"

#include "chrome/renderer/prefetch_helper.h"

#include "chrome/renderer/prerender/prerender_dispatcher.h"

#include "chrome/renderer/prerender/prerender_helper.h"

@@ -92,6 +93,7 @@

#include "third_party/WebKit/public/web/WebLocalFrame.h"

#include "third_party/WebKit/public/web/WebPluginContainer.h"

#include "third_party/WebKit/public/web/WebPluginParams.h"

+#include "third_party/WebKit/public/web/WebPluginPlaceholder.h"

#include "third_party/WebKit/public/web/WebSecurityOrigin.h"

#include "third_party/WebKit/public/web/WebSecurityPolicy.h"

#include "ui/base/l10n/l10n_util.h"

@@ -547,6 +549,15 @@ const Extension* ChromeContentRendererClient::GetExtensionByOrigin(

}

#endif

+scoped_ptr<blink::WebPluginPlaceholder>

+ChromeContentRendererClient::CreatePluginPlaceholder(

+ content::RenderFrame* render_frame,

+ blink::WebLocalFrame* frame,

+ const blink::WebPluginParams& orig_params) {

+ return CreateShadowDOMPlaceholderForPluginInfo(

+ render_frame, frame, orig_params);

bool ChromeContentRendererClient::OverrideCreatePlugin(

content::RenderFrame* render_frame,

WebLocalFrame* frame,

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.h ('k') | chrome/renderer/chrome_content_renderer_client_browsertest.cc » ('j') | no next file with comments »