content/renderer/render_frame_impl.h - Issue 649873006: Enable shadow DOM-based "missing plugin" placeholder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 649873006: Enable shadow DOM-based "missing plugin" placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: formatting etc Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/content_renderer_client.cc ('K') | « content/public/renderer/content_renderer_client.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index dad7b18773ce5c89a08f5379c368f94748fff81e..5376ed5f9dc4807384a69bdd68dfc05672e6f9fc 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -282,6 +282,9 @@ class CONTENT_EXPORT RenderFrameImpl

v8::Handle<v8::Context> context) override;

// blink::WebFrameClient implementation:

+ virtual blink::WebPluginPlaceholder* createPluginPlaceholder(

no sievers 2014/10/29 22:54:04 nit: drop 'virtual' since you have 'override'

jbroman 2014/10/29 23:10:48 Done. When I originally wrote this, I think the pr

+ blink::WebLocalFrame*,

+ const blink::WebPluginParams&) override;

virtual blink::WebPlugin* createPlugin(blink::WebLocalFrame* frame,

const blink::WebPluginParams& params);

// TODO(jrummell): Remove this method once blink updated.