content/public/renderer/content_renderer_client.cc - Issue 649873006: Enable shadow DOM-based "missing plugin" placeholder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/content_renderer_client.cc

Issue 649873006: Enable shadow DOM-based "missing plugin" placeholder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed deleting this in the previous patch set Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc ('K') | « content/public/renderer/content_renderer_client.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/content_renderer_client.cc

diff --git a/content/public/renderer/content_renderer_client.cc b/content/public/renderer/content_renderer_client.cc

index 76f27ee59e013128960b07c82102b1c7bd8b0f88..bd02060755b84dedd031eb7e24d559ebe570c1d3 100644

--- a/content/public/renderer/content_renderer_client.cc

+++ b/content/public/renderer/content_renderer_client.cc

@@ -4,6 +4,8 @@

#include "content/public/renderer/content_renderer_client.h"

+#include "third_party/WebKit/public/web/WebPluginPlaceholder.h"

namespace content {

SkBitmap* ContentRendererClient::GetSadPluginBitmap() {

@@ -14,6 +16,14 @@ SkBitmap* ContentRendererClient::GetSadWebViewBitmap() {

return NULL;

}

+scoped_ptr<blink::WebPluginPlaceholder>

+ContentRendererClient::CreatePluginPlaceholder(

+ RenderFrame* render_frame,

+ blink::WebLocalFrame* frame,

+ const blink::WebPluginParams& params) {

+ return nullptr;

bool ContentRendererClient::OverrideCreatePlugin(

RenderFrame* render_frame,

blink::WebLocalFrame* frame,