sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart - Issue 649873003: dart2js: Use computed classes/statics from code-emitter-task in new emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart

Issue 649873003: dart2js: Use computed classes/statics from code-emitter-task in new emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart

index f5413048c9553a1e7619fdfb171fec78215618f8..b15bbafd38ea558ff6211502acedb44c059aef81 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/program_builder.dart

@@ -47,8 +47,8 @@ class ProgramBuilder {

Iterable<Element> neededStatics = backend.generatedCode.keys

.where((Element e) => !e.isInstanceMember && !e.isField);

- Elements.sortedByPosition(neededClasses).forEach(_registry.registerElement);

- Elements.sortedByPosition(neededStatics).forEach(_registry.registerElement);

+ _task.outputClassLists.forEach(_registry.registerElements);

+ _task.outputStaticLists.forEach(_registry.registerElements);

// TODO(kasperl): There's code that implicitly needs access to the special

// $ holder so we have to register that. Can we track if we have to?

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_emitter/registry.dart » ('j') | no next file with comments »