Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 649793003: Fix windows static library build of app_shell_browsertests. (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix windows static library build of app_shell / app_shell_browsertests / app_shell_unittests. BUG=399363 Committed: https://crrev.com/6c0aaa6ee9ff659cbae080363004b4ff21002ab3 Cr-Commit-Position: refs/heads/master@{#299236}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M extensions/shell/app_shell.gyp View 1 2 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
lfg
PTAL
6 years, 2 months ago (2014-10-10 20:59:24 UTC) #2
Yoyo Zhou
LGTM, thanks for looking at this. https://codereview.chromium.org/649793003/diff/1/extensions/shell/app_shell.gyp File extensions/shell/app_shell.gyp (right): https://codereview.chromium.org/649793003/diff/1/extensions/shell/app_shell.gyp#newcode203 extensions/shell/app_shell.gyp:203: ['OS=="win"', { You ...
6 years, 2 months ago (2014-10-10 21:01:49 UTC) #3
lfg
Please, take another look. I should have tested this before, but app_shell and app_shell_unittests have ...
6 years, 2 months ago (2014-10-10 21:17:15 UTC) #4
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-10 21:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649793003/160001
6 years, 2 months ago (2014-10-10 22:07:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/62120)
6 years, 2 months ago (2014-10-10 22:17:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649793003/160001
6 years, 2 months ago (2014-10-10 22:22:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/62120)
6 years, 2 months ago (2014-10-10 22:30:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649793003/160001
6 years, 2 months ago (2014-10-11 05:30:53 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:160001)
6 years, 2 months ago (2014-10-11 05:31:21 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 05:32:29 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c0aaa6ee9ff659cbae080363004b4ff21002ab3
Cr-Commit-Position: refs/heads/master@{#299236}

Powered by Google App Engine
This is Rietveld 408576698