Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Issue 649793002: [Suggestions] Headers cleanup for iOS image encoder (Closed)

Created:
6 years, 2 months ago by Mathieu
Modified:
6 years, 2 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Headers cleanup for iOS image encoder BUG=None Committed: https://crrev.com/3377c626623cb1bcb9b39d0508360a690e8d9818 Cr-Commit-Position: refs/heads/master@{#299188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -41 lines) Patch
M components/suggestions.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M components/suggestions/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
D components/suggestions/image_encoder_ios.h View 1 chunk +0 lines, -24 lines 0 comments Download
M components/suggestions/image_encoder_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/image_manager.cc View 1 chunk +1 line, -6 lines 0 comments Download
M components/suggestions/image_manager_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mathieu
Have a look!
6 years, 2 months ago (2014-10-10 20:43:14 UTC) #2
blundell
LGTM
6 years, 2 months ago (2014-10-10 20:44:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649793002/1
6 years, 2 months ago (2014-10-10 20:47:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 21:13:07 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:13:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3377c626623cb1bcb9b39d0508360a690e8d9818
Cr-Commit-Position: refs/heads/master@{#299188}

Powered by Google App Engine
This is Rietveld 408576698