runtime/vm/pages.cc - Issue 649743002: - Fine grain locking of free list when sweeping concurrently.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/pages.cc

Issue 649743002: - Fine grain locking of free list when sweeping concurrently. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/pages.cc

===================================================================

--- runtime/vm/pages.cc (revision 41045)

+++ runtime/vm/pages.cc (working copy)

@@ -722,7 +722,7 @@

FreeList* freelist = &freelist_[HeapPage::kExecutable];

while (page != NULL) {

HeapPage* next_page = page->next();

- bool page_in_use = sweeper.SweepPage(page, freelist);

+ bool page_in_use = sweeper.SweepPage(page, freelist, true);

if (page_in_use) {

prev_page = page;

} else {

@@ -740,7 +740,8 @@

page = pages_;

while (page != NULL) {

HeapPage* next_page = page->next();

- bool page_in_use = sweeper.SweepPage(page, &freelist_[page->type()]);

+ bool page_in_use = sweeper.SweepPage(

+ page, &freelist_[page->type()], true);

if (page_in_use) {

prev_page = page;

} else {

« runtime/vm/gc_sweeper.h ('K') | « runtime/vm/gc_sweeper.cc ('k') | no next file » | no next file with comments »