Moves some files into mojo/common

Moves some files into mojo/common

BUG=none
TEST=none
R=darin@chromium.org, viettrungluu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233680

[sky, 2013-11-07 18:31:59]

https://codereview.chromium.org/64973002/diff/1/mojo/mojo.gyp
File mojo/mojo.gyp (right):

https://codereview.chromium.org/64973002/diff/1/mojo/mojo.gyp#newcode53
mojo/mojo.gyp:53:
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
Not sure why I had to add this, but without it I get link errors when building
mojo_common_unittests and AnnotateHappensAfter.

[darin (slow to review), 2013-11-07 18:41:23]

LGTM

https://codereview.chromium.org/64973002/diff/1/mojo/common/scoped_message_pi...
File mojo/common/scoped_message_pipe.h (right):

https://codereview.chromium.org/64973002/diff/1/mojo/common/scoped_message_pi...
mojo/common/scoped_message_pipe.h:17: class MOJO_COMMON_EXPORT ScopedMessagePipe
{
This may end up being something we just want to have in public/utility/ since it
doesn't depend on base (public/system/macros.h also has a version of
DISALLOW_COPY_AND_ASSIGN). But, moving this here for now seems fine.

[commit-bot: I haz the power, 2013-11-07 18:44:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/64973002/1

[sky, 2013-11-07 18:45:03]

On 2013/11/07 18:41:23, darin wrote:
> LGTM
> 
>
https://codereview.chromium.org/64973002/diff/1/mojo/common/scoped_message_pi...
> File mojo/common/scoped_message_pipe.h (right):
> 
>
https://codereview.chromium.org/64973002/diff/1/mojo/common/scoped_message_pi...
> mojo/common/scoped_message_pipe.h:17: class MOJO_COMMON_EXPORT
ScopedMessagePipe
> {
> This may end up being something we just want to have in public/utility/ since
it
> doesn't depend on base (public/system/macros.h also has a version of
> DISALLOW_COPY_AND_ASSIGN). But, moving this here for now seems fine.

If public/XXX is going to be part of the SDK, which implies long term support,
then I think the bar should be really REALLY high for things being placed there.

[Ben Goodger (Google), 2013-11-07 18:45:35]

add a README.chromium to this dir explaining what the purpose of this dir is?
Maybe a DEPS file too?

[sky, 2013-11-07 20:36:21]

Committed patchset #1 manually as r233680 (presubmit successful).