Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6776)

Unified Diff: chrome/browser/plugins/plugin_observer.cc

Issue 649683010: Standardize usage of virtual/override/final in chrome/browser/plugins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_observer.h ('k') | chrome/browser/plugins/plugin_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_observer.cc
diff --git a/chrome/browser/plugins/plugin_observer.cc b/chrome/browser/plugins/plugin_observer.cc
index 2572b29df9c3db6334fb66f11c5a68cb9b55fb4d..913633fa749bf26e8d7b463652f6f6931213f9f9 100644
--- a/chrome/browser/plugins/plugin_observer.cc
+++ b/chrome/browser/plugins/plugin_observer.cc
@@ -64,15 +64,15 @@ class ConfirmInstallDialogDelegate : public TabModalConfirmDialogDelegate,
scoped_ptr<PluginMetadata> plugin_metadata);
// TabModalConfirmDialogDelegate methods:
- virtual base::string16 GetTitle() override;
- virtual base::string16 GetDialogMessage() override;
- virtual base::string16 GetAcceptButtonTitle() override;
- virtual void OnAccepted() override;
- virtual void OnCanceled() override;
+ base::string16 GetTitle() override;
+ base::string16 GetDialogMessage() override;
+ base::string16 GetAcceptButtonTitle() override;
+ void OnAccepted() override;
+ void OnCanceled() override;
// WeakPluginInstallerObserver methods:
- virtual void DownloadStarted() override;
- virtual void OnlyWeakObserversLeft() override;
+ void DownloadStarted() override;
+ void OnlyWeakObserversLeft() override;
private:
content::WebContents* web_contents_;
@@ -131,14 +131,14 @@ class ReloadPluginInfoBarDelegate : public ConfirmInfoBarDelegate {
private:
ReloadPluginInfoBarDelegate(content::NavigationController* controller,
const base::string16& message);
- virtual ~ReloadPluginInfoBarDelegate();
+ ~ReloadPluginInfoBarDelegate() override;
// ConfirmInfobarDelegate:
- virtual int GetIconID() const override;
- virtual base::string16 GetMessageText() const override;
- virtual int GetButtons() const override;
- virtual base::string16 GetButtonLabel(InfoBarButton button) const override;
- virtual bool Accept() override;
+ int GetIconID() const override;
+ base::string16 GetMessageText() const override;
+ int GetButtons() const override;
+ base::string16 GetButtonLabel(InfoBarButton button) const override;
+ bool Accept() override;
content::NavigationController* controller_;
base::string16 message_;
@@ -214,19 +214,19 @@ class PluginObserver::PluginPlaceholderHost : public PluginInstallerObserver {
}
// PluginInstallerObserver methods:
- virtual void DownloadStarted() override {
+ void DownloadStarted() override {
observer_->Send(new ChromeViewMsg_StartedDownloadingPlugin(routing_id_));
}
- virtual void DownloadError(const std::string& msg) override {
+ void DownloadError(const std::string& msg) override {
observer_->Send(new ChromeViewMsg_ErrorDownloadingPlugin(routing_id_, msg));
}
- virtual void DownloadCancelled() override {
+ void DownloadCancelled() override {
observer_->Send(new ChromeViewMsg_CancelledDownloadingPlugin(routing_id_));
}
- virtual void DownloadFinished() override {
+ void DownloadFinished() override {
observer_->Send(new ChromeViewMsg_FinishedDownloadingPlugin(routing_id_));
}
« no previous file with comments | « chrome/browser/plugins/plugin_observer.h ('k') | chrome/browser/plugins/plugin_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698