chrome/browser/plugins/plugin_installer.h - Issue 649683010: Standardize usage of virtual/override/final in chrome/browser/plugins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_installer.h

Issue 649683010: Standardize usage of virtual/override/final in chrome/browser/plugins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/plugins/plugin_installer.h

diff --git a/chrome/browser/plugins/plugin_installer.h b/chrome/browser/plugins/plugin_installer.h

index 06ffaf43305c678408a139806333aeb5a1890a11..7095daf41a72c7a1c1a14cd16d9f8d85dc2cd484 100644

--- a/chrome/browser/plugins/plugin_installer.h

+++ b/chrome/browser/plugins/plugin_installer.h

@@ -31,10 +31,10 @@ class PluginInstaller : public content::DownloadItem::Observer {

};

PluginInstaller();

- virtual ~PluginInstaller();

+ ~PluginInstaller() override;

- virtual void OnDownloadUpdated(content::DownloadItem* download) override;

- virtual void OnDownloadDestroyed(content::DownloadItem* download) override;

+ void OnDownloadUpdated(content::DownloadItem* download) override;

+ void OnDownloadDestroyed(content::DownloadItem* download) override;

void AddObserver(PluginInstallerObserver* observer);

void RemoveObserver(PluginInstallerObserver* observer);

« no previous file with comments | « chrome/browser/plugins/plugin_infobar_delegates.h ('k') | chrome/browser/plugins/plugin_installer_observer.h » ('j') | no next file with comments »