chrome/browser/plugins/plugin_info_message_filter.h - Issue 649683010: Standardize usage of virtual/override/final in chrome/browser/plugins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_info_message_filter.h

Issue 649683010: Standardize usage of virtual/override/final in chrome/browser/plugins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/plugins/chrome_plugin_service_filter.h ('k') | chrome/browser/plugins/plugin_info_message_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_info_message_filter.h

diff --git a/chrome/browser/plugins/plugin_info_message_filter.h b/chrome/browser/plugins/plugin_info_message_filter.h

index 2c8d919571b863700466b65eb8db4b81fa3f6dd4..6819a0b3fdd273402f8d6eeae9f6b26861897ecb 100644

--- a/chrome/browser/plugins/plugin_info_message_filter.h

+++ b/chrome/browser/plugins/plugin_info_message_filter.h

@@ -78,15 +78,15 @@ class PluginInfoMessageFilter : public content::BrowserMessageFilter {

PluginInfoMessageFilter(int render_process_id, Profile* profile);

// content::BrowserMessageFilter methods:

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OnDestruct() const override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void OnDestruct() const override;

private:

friend struct content::BrowserThread::DeleteOnThread<

content::BrowserThread::UI>;

friend class base::DeleteHelper<PluginInfoMessageFilter>;

- virtual ~PluginInfoMessageFilter();

+ ~PluginInfoMessageFilter() override;

void OnGetPluginInfo(int render_frame_id,

const GURL& url,