Source/modules/webmidi/MIDIOutput.h - Issue 649683006: Web MIDI: add blink APIs to notify device connection events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIOutput.h

Issue 649683006: Web MIDI: add blink APIs to notify device connection events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address a comment at #21 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/MIDIOutput.h

diff --git a/Source/modules/webmidi/MIDIOutput.h b/Source/modules/webmidi/MIDIOutput.h

index 2b8d0c1930210d82c09c42374ae6338feb654fee..3b0170ee815184bc12fdd46f5d61784bf3ca4fe1 100644

--- a/Source/modules/webmidi/MIDIOutput.h

+++ b/Source/modules/webmidi/MIDIOutput.h

@@ -42,7 +42,7 @@ class MIDIAccess;

class MIDIOutput final : public MIDIPort {

DEFINE_WRAPPERTYPEINFO();

public:

- static MIDIOutput* create(MIDIAccess*, unsigned portIndex, const String& id, const String& manufacturer, const String& name, const String& version);

+ static MIDIOutput* create(MIDIAccess*, unsigned portIndex, const String& id, const String& manufacturer, const String& name, const String& version, bool isActive);

virtual ~MIDIOutput();

void send(Uint8Array*, double timestamp, ExceptionState&);

@@ -55,7 +55,7 @@ public:

virtual void trace(Visitor*) override;

private:

- MIDIOutput(MIDIAccess*, unsigned portIndex, const String& id, const String& manufacturer, const String& name, const String& version);

+ MIDIOutput(MIDIAccess*, unsigned portIndex, const String& id, const String& manufacturer, const String& name, const String& version, bool isActive);

unsigned m_portIndex;

};

« no previous file with comments | « Source/modules/webmidi/MIDIInput.cpp ('k') | Source/modules/webmidi/MIDIOutput.cpp » ('j') | no next file with comments »