Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.cpp

Issue 649683006: Web MIDI: add blink APIs to notify device connection events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address a comment at #21 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.h ('k') | Source/modules/webmidi/MIDIAccessor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccessInitializer.cpp
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.cpp b/Source/modules/webmidi/MIDIAccessInitializer.cpp
index b1d1013dac8e0aed3bef0d3238bbb74611a09c3a..7fff2affa7b652bf8ba6a71304a0d224c7b5a4fb 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.cpp
+++ b/Source/modules/webmidi/MIDIAccessInitializer.cpp
@@ -55,16 +55,30 @@ ScriptPromise MIDIAccessInitializer::start()
return promise;
}
-void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version)
+void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive)
{
ASSERT(m_accessor);
- m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeInput, version));
+ m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeInput, version, isActive));
}
-void MIDIAccessInitializer::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version)
+void MIDIAccessInitializer::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive)
{
ASSERT(m_accessor);
- m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeOutput, version));
+ m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeOutput, version, isActive));
+}
+
+void MIDIAccessInitializer::didSetInputPortState(unsigned portIndex, bool isActive)
+{
+ // didSetInputPortState() is not allowed to call before didStartSession()
+ // is called. Once didStartSession() is called, MIDIAccessorClient methods
+ // are delegated to MIDIAccess. See constructor of MIDIAccess.
+ ASSERT_NOT_REACHED();
+}
+
+void MIDIAccessInitializer::didSetOutputPortState(unsigned portIndex, bool isActive)
+{
+ // See comments on didSetInputPortState().
+ ASSERT_NOT_REACHED();
}
void MIDIAccessInitializer::didStartSession(bool success, const String& error, const String& message)
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.h ('k') | Source/modules/webmidi/MIDIAccessor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698