Source/modules/webmidi/MIDIInput.h - Issue 649683006: Web MIDI: add blink APIs to notify device connection events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIInput.h

Issue 649683006: Web MIDI: add blink APIs to notify device connection events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments at #16 (build is not finished yet in local slow machine) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/MIDIInput.h

diff --git a/Source/modules/webmidi/MIDIInput.h b/Source/modules/webmidi/MIDIInput.h

index c88594e6d90108eb67a0a87da85f2aae9739881d..6e20022c91adef436c3a2c75d514c78bfa10510d 100644

--- a/Source/modules/webmidi/MIDIInput.h

+++ b/Source/modules/webmidi/MIDIInput.h

@@ -41,7 +41,7 @@ class MIDIAccess;

class MIDIInput final : public MIDIPort {

DEFINE_WRAPPERTYPEINFO();

public:

- static MIDIInput* create(MIDIAccess*, const String& id, const String& manufacturer, const String& name, const String& version);

+ static MIDIInput* create(MIDIAccess*, const String& id, const String& manufacturer, const String& name, const String& version, bool isActive);

virtual ~MIDIInput() { }

DEFINE_ATTRIBUTE_EVENT_LISTENER(midimessage);

@@ -55,7 +55,7 @@ public:

virtual void trace(Visitor*) override;

private:

- MIDIInput(MIDIAccess*, const String& id, const String& manufacturer, const String& name, const String& version);

+ MIDIInput(MIDIAccess*, const String& id, const String& manufacturer, const String& name, const String& version, bool isActive);

};

} // namespace blink

« Source/modules/webmidi/MIDIAccessInitializer.cpp ('K') | « Source/modules/webmidi/MIDIAccessorClient.h ('k') | Source/modules/webmidi/MIDIInput.cpp » ('j') | no next file with comments »