Source/modules/webmidi/MIDIAccessor.h - Issue 649683006: Web MIDI: add blink APIs to notify device connection events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIAccessor.h

Issue 649683006: Web MIDI: add blink APIs to notify device connection events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments at #16 (build is not finished yet in local slow machine) Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/webmidi/MIDIAccessInitializer.cpp ('K') | « Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | Source/modules/webmidi/MIDIAccessor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webmidi/MIDIAccessor.h

diff --git a/Source/modules/webmidi/MIDIAccessor.h b/Source/modules/webmidi/MIDIAccessor.h

index 28adfb46f5909512e741b73cd8fab3ece9575c63..0f81c6130cd0037d96c043e11e2cb5008d0569fc 100644

--- a/Source/modules/webmidi/MIDIAccessor.h

+++ b/Source/modules/webmidi/MIDIAccessor.h

@@ -54,8 +54,13 @@ public:

void setClient(MIDIAccessorClient* client) { m_client = client; }

// WebMIDIAccessorClient

+ // FIXME: Remove deprecated interfaces that do not have |isActive| argument.

virtual void didAddInputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version) override;

virtual void didAddOutputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version) override;

+ virtual void didAddInputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, bool isActive) override;

+ virtual void didAddOutputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, bool isActive) override;

+ virtual void didSetInputPortState(unsigned portIndex, bool isActive) override;

+ virtual void didSetOutputPortState(unsigned portIndex, bool isActive) override;

virtual void didStartSession(bool success, const WebString& error, const WebString& message) override;

virtual void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) override;