Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 649683006: Web MIDI: add blink APIs to notify device connection events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address comments at #7 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webmidi/MIDIAccessInitializer.h
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h
index 58067544bdf962ef7df4ff8f8e24c524706f097c..1ae2d55e452c6c738c6c92562261dae60f7cd653 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.h
+++ b/Source/modules/webmidi/MIDIAccessInitializer.h
@@ -26,13 +26,15 @@ public:
String name;
MIDIPort::MIDIPortTypeCode type;
String version;
+ bool active;
tkent 2014/10/20 05:54:07 should be |isActive|
Takashi Toyoshima 2014/10/20 06:24:18 Done.
- PortDescriptor(const String& id, const String& manufacturer, const String& name, MIDIPort::MIDIPortTypeCode type, const String& version)
+ PortDescriptor(const String& id, const String& manufacturer, const String& name, MIDIPort::MIDIPortTypeCode type, const String& version, bool active)
: id(id)
, manufacturer(manufacturer)
, name(name)
, type(type)
- , version(version) { }
+ , version(version)
+ , active(active) { }
};
static ScriptPromise start(ScriptState* scriptState, const MIDIOptions& options)
@@ -46,8 +48,10 @@ public:
virtual ~MIDIAccessInitializer();
// MIDIAccessorClient
- virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version) override;
- virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version) override;
+ virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool active) override;
+ virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool active) override;
+ virtual void didSetInputPortState(unsigned portIndex, bool active) override;
+ virtual void didSetOutputPortState(unsigned portIndex, bool active) override;
virtual void didStartSession(bool success, const String& error, const String& message) override;
virtual void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) override { }

Powered by Google App Engine
This is Rietveld 408576698