Source/modules/webmidi/MIDIAccess.h - Issue 649683006: Web MIDI: add blink APIs to notify device connection events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIAccess.h

Issue 649683006: Web MIDI: add blink APIs to notify device connection events (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/MIDIAccess.h

diff --git a/Source/modules/webmidi/MIDIAccess.h b/Source/modules/webmidi/MIDIAccess.h

index 2baf97676b10a1ae403be44dcd61474e10c1f129..648f290daf11c858cd5f2ef71d529c1b23582975 100644

--- a/Source/modules/webmidi/MIDIAccess.h

+++ b/Source/modules/webmidi/MIDIAccess.h

@@ -77,8 +77,10 @@ public:

virtual void stop() override;

// MIDIAccessorClient

- virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version) override;

- virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version) override;

+ virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool active) override;

yhirano 2014/10/20 02:14:10 [optional] Is enum more preferable?

Takashi Toyoshima 2014/10/20 05:39:50 See https://codereview.chromium.org/649683006/#msg

+ virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool active) override;

+ virtual void didSetInputPortState(unsigned portIndex, bool active) override;

+ virtual void didSetOutputPortState(unsigned portIndex, bool active) override;

virtual void didStartSession(bool success, const String& error, const String& message) override

{

// This method is for MIDIAccess initialization: MIDIAccessInitializer

« no previous file with comments | « no previous file | Source/modules/webmidi/MIDIAccess.cpp » ('j') | Source/modules/webmidi/MIDIAccessInitializer.h » ('J')