Web MIDI: add blink APIs to notify device connection events

Source/modules/webmidi/MIDIAccessInitializer.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/webmidi/MIDIAccessInitializer.h"
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMError.h"
@@ skipping 37 matching lines @@
     ASSERT(document);
     MIDIController* controller = MIDIController::from(document->frame());
     if (controller) {
         controller->requestSysexPermission(this);
     } else {
         reject(DOMError::create("SecurityError"));
     }
     return promise;
 }
 
-void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version)
+void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool active)
 {
     ASSERT(m_accessor);
-    m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeInput, version));
+    m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeInput, version, active));
 }
 
-void MIDIAccessInitializer::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version)
+void MIDIAccessInitializer::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool active)
 {
     ASSERT(m_accessor);
-    m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeOutput, version));
+    m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeOutput, version, active));
+}
+
+void MIDIAccessInitializer::didSetInputPortState(unsigned portIndex, bool active)
+{
+    ASSERT_NOT_REACHED();

[yhirano, 2014/10/20 02:14:10]

Is this correct? IIUC the browser can fire this notification anytime, right?

[Takashi Toyoshima, 2014/10/20 02:40:25]

Embedder (Chromium) sends, didAddInputPort(), didAddOutputPort(), and
didStartSession() in this order. After that, didSetOutputPort() and
didSetInputPort() are used when a device online state is changed.

IIRC, once didStartSession() is called, these client methods are handled by
another class directly, right?

[Takashi Toyoshima, 2014/10/20 05:39:50]

I added comments here too.

+}
+
+void MIDIAccessInitializer::didSetOutputPortState(unsigned portIndex, bool active)
+{
+    ASSERT_NOT_REACHED();

[yhirano, 2014/10/20 02:14:10]

ditto

[Takashi Toyoshima, 2014/10/20 05:39:50]

ditto

 }
 
 void MIDIAccessInitializer::didStartSession(bool success, const String& error, const String& message)
 {
     ASSERT(m_accessor);
     if (success) {
         resolve(MIDIAccess::create(m_accessor.release(), m_requestSysex, m_portDescriptors, executionContext()));
     } else {
         reject(DOMError::create(error, message));
     }
@@ skipping 11 matching lines @@
 {
     return executionContext()->securityOrigin();
 }
 
 ExecutionContext* MIDIAccessInitializer::executionContext() const
 {
     return scriptState()->executionContext();
 }
 
 } // namespace blink