Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 649683004: aw: Clean up browser_view_renderer.cc/h (Closed)

Created:
6 years, 2 months ago by boliu
Modified:
6 years, 2 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

aw: Clean up browser_view_renderer.cc/h * Remove unneeded includes, using, etc * Use base::debug::ConvertableToTraceFormat * Fix up some comments * Make const a global var BUG= Committed: https://crrev.com/a3434da050b4e46d07a23a99dabed20891e5ec0f Cr-Commit-Position: refs/heads/master@{#299416}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -66 lines) Patch
M android_webview/browser/browser_view_renderer.h View 4 chunks +4 lines, -7 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 11 chunks +13 lines, -59 lines 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
boliu
PTAL
6 years, 2 months ago (2014-10-14 00:39:15 UTC) #2
hush (inactive)
lgtm https://codereview.chromium.org/649683004/diff/1/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/649683004/diff/1/android_webview/browser/browser_view_renderer.cc#newcode45 android_webview/browser/browser_view_renderer.cc:45: const size_t g_tile_area = 256 * 256; since ...
6 years, 2 months ago (2014-10-14 01:01:10 UTC) #3
boliu
https://codereview.chromium.org/649683004/diff/1/android_webview/browser/browser_view_renderer.cc File android_webview/browser/browser_view_renderer.cc (right): https://codereview.chromium.org/649683004/diff/1/android_webview/browser/browser_view_renderer.cc#newcode45 android_webview/browser/browser_view_renderer.cc:45: const size_t g_tile_area = 256 * 256; On 2014/10/14 ...
6 years, 2 months ago (2014-10-14 01:04:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649683004/20001
6 years, 2 months ago (2014-10-14 01:06:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-14 01:31:30 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:33:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3434da050b4e46d07a23a99dabed20891e5ec0f
Cr-Commit-Position: refs/heads/master@{#299416}

Powered by Google App Engine
This is Rietveld 408576698