Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 649663003: bug_chomper: Make server's port configurable. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
borenet
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

bug_chomper: Make server's port configurable. Make 'port' a flag so you can change it from the command line, making the server more flexible and allowing us to change in which port it listen to requests. $ ./run_server.sh --port :8002 BUG=None TEST=see above R=borenet@google.com Committed: https://skia.googlesource.com/skia/+/a658d368defdc9b3dd176b8cfd018aaf061fe9a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tools/bug_chomper/run_server.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/bug_chomper/src/server/server.go View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tfarina
Is this OK?
6 years, 2 months ago (2014-10-11 02:30:55 UTC) #1
borenet
LGTM
6 years, 2 months ago (2014-10-13 13:06:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649663003/1
6 years, 2 months ago (2014-10-13 13:52:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/7)
6 years, 2 months ago (2014-10-13 14:53:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649663003/1
6 years, 2 months ago (2014-10-13 15:00:57 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:43:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as a658d368defdc9b3dd176b8cfd018aaf061fe9a2

Powered by Google App Engine
This is Rietveld 408576698