Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 649633002: android_webview: avoid depending on locale at gyp time. (Closed)

Created:
6 years, 2 months ago by Torne
Modified:
6 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: avoid depending on locale at gyp time. To keep the generated makefiles relatively stable, we sort a number of file lists at gyp time, but this sort ordering is dependent on the calling user's locale. Fix this by forcing LC_COLLATE to "C" in gyp_webview. BUG= NOTRY=true Committed: https://crrev.com/2011089e0e85580237e944b26ef7f9329ecf9061 Cr-Commit-Position: refs/heads/master@{#299103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M android_webview/tools/gyp_webview View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Torne
6 years, 2 months ago (2014-10-10 11:54:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649633002/1
6 years, 2 months ago (2014-10-10 12:32:57 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-10 12:32:59 UTC) #6
Primiano Tucci (use gerrit)
lgtm
6 years, 2 months ago (2014-10-10 13:43:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649633002/1
6 years, 2 months ago (2014-10-10 13:44:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 13:45:02 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 13:45:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2011089e0e85580237e944b26ef7f9329ecf9061
Cr-Commit-Position: refs/heads/master@{#299103}

Powered by Google App Engine
This is Rietveld 408576698