Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 649623002: --no-lazy flag applies also to top-level scripts (Closed)

Created:
6 years, 2 months ago by wingo
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne, marja
CC:
v8-dev, Dmitry Lomov (no reviews)
Project:
v8
Visibility:
Public.

Description

--no-lazy flag applies also to top-level scripts The --lazy flag, currently unused within V8 and its test suites, controls whether top-level functions may be lazily parsed. This commit expands it to also apply to toplevel scripts, which were controllable previously only via the --min_preparse_length flag. R=marja@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
wingo
6 years, 2 months ago (2014-10-10 11:29:06 UTC) #1
wingo
r+? svenpanne, as he has been working on the parser these days and marja is ...
6 years, 2 months ago (2014-10-10 11:50:22 UTC) #3
marja
Humm, I don't really understand this patch... can you give an example of a script ...
6 years, 2 months ago (2014-10-13 09:48:19 UTC) #4
wingo
6 years, 2 months ago (2014-10-13 10:04:18 UTC) #5
On 2014/10/13 09:48:19, marja wrote:
> Humm, I don't really understand this patch... can you give an example of a
> script where this makes a difference?
> 
> (FLAG_LAZY is anyway checked before any function is allowed to be lazy.)

I think it was me who got confused!  I just now tried --no-lazy on a file before
and after this change and it had the same instruction count.  Sorry for the
noise, closing the report.

Powered by Google App Engine
This is Rietveld 408576698