Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 649613002: Binding media stream audio track to speech recognition - bugfix (Closed)

Created:
6 years, 2 months ago by burnik
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, glider+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Binding media stream audio track to speech recognition - bugfix. Shared memory initialization in unit test. BUG=408940, 422164 TEST=Memory bot for content_unittests Committed: https://crrev.com/cce6c353bb3ae0a17d2ca4375585b0ef9f4d6ef5 Cr-Commit-Position: refs/heads/master@{#299101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
burnik
Please, review the bug fix.
6 years, 2 months ago (2014-10-10 10:12:36 UTC) #2
no longer working on chromium
On 2014/10/10 10:12:36, burnik wrote: > Please, review the bug fix. lgtm
6 years, 2 months ago (2014-10-10 12:27:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649613002/1
6 years, 2 months ago (2014-10-10 12:28:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 13:16:46 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 13:17:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cce6c353bb3ae0a17d2ca4375585b0ef9f4d6ef5
Cr-Commit-Position: refs/heads/master@{#299101}

Powered by Google App Engine
This is Rietveld 408576698