components/nacl/loader/nacl_listener.cc - Issue 649603004: Non-SFI NaCl: Batch-open resource files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_listener.cc

Issue 649603004: Non-SFI NaCl: Batch-open resource files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_listener.cc

diff --git a/components/nacl/loader/nacl_listener.cc b/components/nacl/loader/nacl_listener.cc

index 359e02cb74861127e06c7523494dec068fd3b571..177be6eff243a7ecdec2a930f9286ead0a49050f 100644

--- a/components/nacl/loader/nacl_listener.cc

+++ b/components/nacl/loader/nacl_listener.cc

@@ -424,6 +424,10 @@ void NaClListener::OnStart(const nacl::NaClStartParams& params) {

args->nexe_desc = NaClDescCreateWithFilePathMetadata(nexe_file,

file_path_str.c_str());

+ // TODO(yusukes): Support pre-opening resource files.

+ CHECK(params.resource_files.empty());

+ CHECK(params.resource_keys.empty());

int exit_status;

if (!NaClChromeMainStart(nap, args, &exit_status))

NaClExit(1);