ipc/ipc_channel_nacl.cc - Issue 649603004: Non-SFI NaCl: Batch-open resource files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_nacl.cc

Issue 649603004: Non-SFI NaCl: Batch-open resource files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_channel_nacl.cc

diff --git a/ipc/ipc_channel_nacl.cc b/ipc/ipc_channel_nacl.cc

index 783ee2620603febd27e669eab58bc074c587d288..e1cccb3c0156f5fb952393ae03399a0de49e30f4 100644

--- a/ipc/ipc_channel_nacl.cc

+++ b/ipc/ipc_channel_nacl.cc

@@ -37,7 +37,7 @@ bool ReadDataOnReaderThread(int pipe, MessageContents* contents) {

return false;

contents->data.resize(Channel::kReadBufferSize);

- contents->fds.resize(FileDescriptorSet::kMaxDescriptorsPerMessage);

+ contents->fds.resize(NACL_ABI_IMC_DESC_MAX);

NaClAbiNaClImcMsgIoVec iov = { &contents->data[0], contents->data.size() };

NaClAbiNaClImcMsgHdr msg = {