Non-SFI NaCl: Batch-open resource files

ipc/ipc_channel_nacl.cc

Index: ipc/ipc_channel_nacl.cc
diff --git a/ipc/ipc_channel_nacl.cc b/ipc/ipc_channel_nacl.cc
index 783ee2620603febd27e669eab58bc074c587d288..e1cccb3c0156f5fb952393ae03399a0de49e30f4 100644
--- a/ipc/ipc_channel_nacl.cc
+++ b/ipc/ipc_channel_nacl.cc
@@ -37,7 +37,7 @@ bool ReadDataOnReaderThread(int pipe, MessageContents* contents) {
     return false;
 
   contents->data.resize(Channel::kReadBufferSize);
-  contents->fds.resize(FileDescriptorSet::kMaxDescriptorsPerMessage);
+  contents->fds.resize(NACL_ABI_IMC_DESC_MAX);

[teravest, 2014/11/10 20:36:12]

Won't this still limit the number of fds to 8 (instead of the 128 from the ipc/
change?)

[Yusuke Sato, 2014/11/11 00:58:35]

It's still limited to 8 and I think that's fine because ipc_channel_nacl.cc is
for sending message from trusted NaCl code to untrusted (and vice versa) and
there is no IRT that requires lots of batch FD passing (for example, we don't
have an IRT like open_resource_batch.)

 
   NaClAbiNaClImcMsgIoVec iov = { &contents->data[0], contents->data.size() };
   NaClAbiNaClImcMsgHdr msg = {