Non-SFI NaCl: Batch-open resource files

ppapi/c/private/ppb_nacl_private.h

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
-/* From private/ppb_nacl_private.idl modified Fri Jan 23 09:09:44 2015. */
+/* From private/ppb_nacl_private.idl modified Wed Feb  4 14:24:53 2015. */
 
 #ifndef PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
 #define PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
 
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_macros.h"
 #include "ppapi/c/pp_stdint.h"
 #include "ppapi/c/pp_var.h"
@@ skipping 167 matching lines @@
 typedef void (*PP_OpenResourceCompletionCallback)(void* user_data,
                                                   PP_FileHandle file_handle);
 /**
  * @}
  */
 
 /**
  * @addtogroup Structs
  * @{
  */
-/* Corresponds to NaClFileInfo in
- * native_client/src/trusted/validator/nacl_file_info.h */
+/* Corresponds to NaClFileInfo in native_client/src/public/nacl_file_info.h */

[Mark Seaborn, 2015/02/12 03:57:34]

If you rebase, you'll find this comment is gone (since
native_client/src/public/nacl_file_info.h is removed).

 struct PP_NaClFileInfo {
   PP_FileHandle handle;
   /* See NaClFileToken comment in nacl_file_info.h */
   uint64_t token_lo;
   uint64_t token_hi;
 };
 /**
  * @}
  */
 
@@ skipping 111 matching lines @@
    * of attributes supported by LLVM in its -mattr= option:
    *   http://llvm.org/docs/CommandGuide/llc.html#cmdoption-mattr */
   struct PP_Var (*GetCpuFeatureAttrs)(void);
   /* Downloads the .nexe file at the given URL to a file, and sets |file_info|
    * to information for a handle to a file containing its contents.
    * If metadata for identity-based validation caching is available
    * then it sets token information in |file_info| (otherwise left untouched).
    */
   void (*DownloadNexe)(PP_Instance instance,
                        const char* url,
+                       PP_Bool download_resource_files,

[Mark Seaborn, 2015/02/12 03:57:34]

How about "prefetch_resource_files", to be more descriptive?

[Yusuke Sato, 2015/02/13 23:01:17]

Done. (removed)

                        struct PP_NaClFileInfo* file_info,
                        struct PP_CompletionCallback callback);
   /* Reports the status of sel_ldr for UMA reporting.
    * |max_status| has to be provided because the implementation of this
    * interface can't access the NaClErrorCode enum.
    */
   void (*ReportSelLdrStatus)(PP_Instance instance,
                              int32_t load_status,
                              int32_t max_status);
   /* Logs time taken by an operation to UMA histograms.
@@ skipping 19 matching lines @@
                      void* stream_handler_user_data);
 };
 
 typedef struct PPB_NaCl_Private_1_0 PPB_NaCl_Private;
 /**
  * @}
  */
 
 #endif  /* PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_ */