Non-SFI NaCl: Batch-open resource files

components/nacl/browser/nacl_file_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NACL_BROWSER_NACL_FILE_HOST_H_
 #define COMPONENTS_NACL_BROWSER_NACL_FILE_HOST_H_
 
 #include <string>
+#include <vector>
 
 #include "base/memory/ref_counted.h"
 
 class GURL;
 
 namespace base {
 class FilePath;
 }
 
 namespace IPC {
@@ skipping 15 matching lines @@
     scoped_refptr<nacl::NaClHostMessageFilter> nacl_host_message_filter,
     const std::string& filename,
     bool is_executable,
     IPC::Message* reply_msg);
 
 // Return true if the filename requested is valid for opening.
 // Sets file_to_open to the base::FilePath which we will attempt to open.
 bool PnaclCanOpenFile(const std::string& filename,
                       base::FilePath* file_to_open);
 
-// Opens a NaCl executable file for reading and executing.
-void OpenNaClExecutable(
+// Opens NaCl resource files for reading and/or executing.
+void OpenNaClResources(
     scoped_refptr<nacl::NaClHostMessageFilter> nacl_host_message_filter,
     int render_view_id,
-    const GURL& file_url,
+    const GURL& executable_file_url,
+    const std::vector<GURL>& resource_urls,

[Mark Seaborn, 2015/02/02 23:21:50]

What is the difference between executable_file_url and resource_urls here?

Could executable_file_url just be passed as the first entry in the resource_urls
vector, so that it doesn't need to be special-cased?

Treating them as separate seems to introduce a lot of duplication into
nacl_file_host.cc.

[Yusuke Sato, 2015/02/04 02:00:28]

Done.

     IPC::Message* reply_msg);
 
 }  // namespace nacl_file_host
 
 #endif  // COMPONENTS_NACL_BROWSER_NACL_FILE_HOST_H_